test: Improve test flakiness #27556
Closed
test: Improve test flakiness #27556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [75ab876]
Page Load Metrics (1863 ± 58 ms)
Bundle size diffs
|
legobeat
reviewed
Oct 3, 2024
| @@ -118,7 +117,7 @@ describe('Transfer custom tokens @no-mmi', function () { | |||
| // transfer token from dapp | |||
| await openDapp(driver, contractAddress); | |||
| await driver.clickElement({ text: 'Transfer Tokens', tag: 'button' }); | |||
| await switchToNotificationWindow(driver); | |||
| await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog); | |||
There was a problem hiding this comment.
Why does this improve flakiness? What is the cause of the issue being solved?
There was a problem hiding this comment.
This was just refactoring the deprecated method, mainly there is no real flakiness on this test. Multiple re runs of it don't show any.
Builds ready [db58611]
Page Load Metrics (2025 ± 101 ms)
Bundle size diffs
|
|
Builds ready [f5117a5]
Page Load Metrics (1737 ± 61 ms)
Bundle size diffs
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the flakiness tests:
Removes deprecated switchToNotification window: "Transfer custom tokens @no-mmi transfer custom tokens from dapp customizing gas values"
Related issues
Fixes: #22563 #24633
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist